Merged
Conversation
rcambrj
commented
Oct 14, 2025
| @@ -0,0 +1,56 @@ | |||
| --- | |||
Contributor
Author
There was a problem hiding this comment.
this file appeared after a successful make run 🤔
rytswd
reviewed
Oct 14, 2025
Comment on lines
-154
to
+155
| metav1.TypeMeta `json:",inline"` | ||
| metav1.ListMeta `json:"metadata,omitempty"` | ||
| metav1.TypeMeta ` json:",inline"` | ||
| metav1.ListMeta ` json:"metadata,omitempty"` |
Contributor
There was a problem hiding this comment.
How did you end up with this change?
Contributor
Author
There was a problem hiding this comment.
I put golangci-lint into the devshell and ran it. The pipeline was rejecting some formatting, so I had no choice 😄
fernando-villalba
approved these changes
Oct 14, 2025
rcambrj
commented
Oct 14, 2025
| WebhookServer: webhookServer, | ||
| HealthProbeBindAddress: probeAddr, | ||
| LeaderElection: enableLeaderElection, | ||
| LeaderElectionID: "6844ffa5.my.domain", |
Contributor
Author
There was a problem hiding this comment.
what should this be?
rytswd
approved these changes
Oct 14, 2025
Contributor
rytswd
left a comment
rytswd
left a comment
There was a problem hiding this comment.
Mostly sensible it seems, we can iterate as we find more about best setup
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main goal of this change is to get
make runto bring up a reconciler process.go.work.sumgolangci-lint fmtand addsgolangci-lintto the devshellI intend for the last three points to be temporary, the current goal being getting something running.